Reset the forwarded config to empty for @use and meta.load-module() #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #827 I made configuration never be null, but this turns out to be overkill: we still need a way for _loadModule() and _execute() to distinguish between "use the existing configuration" (for @forward) and "use no configuration" (for an unconfigured @use or meta.load-module()). We now use null as a sentinel value there, while still ensuring that _configuration is non-nullable. Closes #854
jathak
approved these changes
Oct 21, 2019
| var builtInModule = _builtInModules[url]; | ||
| if (builtInModule != null) { | ||
| if (configuration.isNotEmpty) { | ||
| if (configuration != null && configuration.isNotEmpty) { |
There was a problem hiding this comment.
Would the better style here and in line 661 be configuration?.isNotEmpty ?? false?
There was a problem hiding this comment.
I considered that, but I think the null logic is easier to follow here than trying to follow a bunch of ?s. It's close, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #827 I made configuration never be null, but this turns out to be
overkill: we still need a way for _loadModule() and _execute() to
distinguish between "use the existing configuration" (for @forward)
and "use no configuration" (for an unconfigured @use or
meta.load-module()). We now use null as a sentinel value there, while
still ensuring that _configuration is non-nullable.
Closes #854
See sass/sass-spec#1486