refactor(find): Use new eslint getRules() api #237
Conversation
Breaking change: Requires eslint >= 3.12.0 Starting with version 3.12.0, eslint provides a getRules() API that allows us to directly access the rules rather than trying to load them from the file system. This is cleaner, eliminates a dependency on the internal structure of the eslint codebase, and may even be faster. This change paves the way for further features involving deprecated rules, such as sarbbottam#172 and sarbbottam#188. Closes sarbbottam#211.
randycoulman
force-pushed
the
use-getrules-api
branch
from
a4e1e9b
to
9f94572
Compare
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 216 209 -7
=====================================
- Hits 216 209 -7
Continue to review full report at Codecov.
|
|
I'll leave it open until this evening (EU TZ) to give another chance for feedback. Otherwise, I'm going to squash and merge this around 1600 UTC. |
|
Awesome! I can't wait for this to get merged. But remember when releasing, it's a breaking change due to the need for ESLint >= 3.12.0! |
|
I'd personally prefer to also include #172 in a coming new (major version) release. |
|
@ta2edchimp That sounds like a good plan. I'll start working on it as soon as I can, but it might be a week before I can get to it. If someone else wants to run with it, feel free, but let me know so I don't duplicate effort. |
Breaking change: Requires eslint >= 3.12.0
Starting with version 3.12.0, eslint provides a getRules() API that allows us to directly access the rules rather than trying to load them from the file system. This is cleaner, eliminates a dependency on the internal structure of the eslint codebase.
This change paves the way for further features involving deprecated rules, such as #172 and #188.
Note that eslint returns a
Mapobject containing the rules, so we can’t useObject.keys()to get the keys out.We are not yet using the rule objects themselves, so the test stubs just return empty objects for now.
Closes #211.