chore(release): releasing 2.0.0 manually #274
Conversation
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 209 209
=====================================
Hits 209 209Continue to review full report at Codecov.
|
|
As already mentioned elsewhere, the automatic sematic-release process is broken. To get #237 released (and to eventually get #270 merged and released) I had to do a manual release. Pushing the changes directly is blocked, therefore this PR, which requires a review ( @sarbbottam @ljharb I summon you ... please help — and finally approve 😜 ). I'd also suggest to make a clean up after bringing #270 out the door, and to stay with manually releasing (as iirc we already concluded) ... |
Since we are transpiling into `dist`, that directory s required to be included within the package, but `src` and `test` are not.
| node_modules/ | ||
| .nyc_output/ | ||
| coverage/ | ||
| src/ |
There was a problem hiding this comment.
i'm really not a fan of npmignoring src or tests - imo both things should always be published so that npm explore foo && npm install && npm test always works.
There was a problem hiding this comment.
That is an absolutely valid point, thank's for bringing that on the table. I'll change that back soon.
Due to a hickup in the automatic release setup, we have to go back to manually releasing (at least version 2.0.0).