Deprecate Conditions and Triggers Saved in handler Callable; Save Condition in signal.extra Instead
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todddialpad
reviewed
Nov 27, 2022
Codecov ReportBase: 88.467% // Head: 88.548% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=============================================
+ Coverage 88.467% 88.548% +0.081%
=============================================
Files 81 81
Lines 6694 6698 +4
Branches 1143 1143
=============================================
+ Hits 5922 5931 +9
+ Misses 531 529 -2
+ Partials 241 238 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ahopkins
reviewed
Dec 6, 2022
ahopkins
previously approved these changes
Dec 14, 2022
|
need to fix the linting issues |
ChihweiLHBird
changed the title
handler Function; Save Condition in signal.extra Instead
ChihweiLHBird
changed the title
handler Function; Save Condition in signal.extra Insteadhandler Callable; Save Condition in signal.extra` Instead
ChihweiLHBird
changed the title
handler Callable; Save Condition in signal.extra` Insteadhandler Callable; Save Condition in signal.extra Instead
ahopkins
approved these changes
Dec 15, 2022
|
I forgot the test case... Will add it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2581
The change in last version of this PR is authored by @ahopkins. Thank you!