Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Signal Handler Test #2630

Merged
merged 2 commits into from Dec 17, 2022
Merged

Method Signal Handler Test #2630

merged 2 commits into from Dec 17, 2022

Conversation

ChihweiLHBird
Copy link
Member

@ChihweiLHBird ChihweiLHBird commented Dec 17, 2022

Test case for #2608

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner December 17, 2022 04:26
@ChihweiLHBird ChihweiLHBird changed the title Method Signal hHandler Test Method Signal Handler Test Dec 17, 2022
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 88.487% // Head: 88.622% // Increases project coverage by +0.134% 🎉

Coverage data is based on head (61bb263) compared to base (a3ff0c1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2630       +/-   ##
=============================================
+ Coverage   88.487%   88.622%   +0.134%     
=============================================
  Files           81        81               
  Lines         6706      6706               
  Branches      1143      1143               
=============================================
+ Hits          5934      5943        +9     
+ Misses         533       527        -6     
+ Partials       239       236        -3     
Impacted Files Coverage Δ
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.691%) ⬆️
sanic/app.py 89.799% <0.000%> (+0.728%) ⬆️
sanic/signals.py 92.907% <0.000%> (+1.418%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 154863d into main Dec 17, 2022
@ahopkins ahopkins deleted the zhiwei/method-signal-handler-test branch December 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants