Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force socket shutdown before close #2607

Merged
merged 3 commits into from Nov 29, 2022
Merged

Force socket shutdown before close #2607

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0094e83
Force socket shutdown before close
ahopkins Nov 27, 2022
9024ab2
Merge branch 'main' into shutdown-socket
ChihweiLHBird Nov 27, 2022
bb0e6f3
Merge branch 'main' into shutdown-socket
ahopkins Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion sanic/mixins/startup.py
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
from multiprocessing import Manager, Pipe, get_context
from multiprocessing.context import BaseContext
from pathlib import Path
from socket import socket
from socket import SHUT_RDWR, socket
from ssl import SSLContext
from typing import (
TYPE_CHECKING,
Expand Down Expand Up @@ -864,6 +864,7 @@ def serve(

sync_manager.shutdown()
for sock in socks:
sock.shutdown(SHUT_RDWR)
sock.close()
socks = []
trigger_events(main_stop, loop, primary)
Expand Down