Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force socket shutdown before close #2607

Merged
merged 3 commits into from Nov 29, 2022
Merged

Force socket shutdown before close #2607

merged 3 commits into from Nov 29, 2022

Conversation

ahopkins
Copy link
Member

From a discussion on Discord, multi-process mode does not allow sockets to be rebound. Forcing socket shutdown from the main upon cleanup seems to solve this as shown here:

image

@ahopkins ahopkins requested a review from a team as a code owner November 27, 2022 08:44
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 87.864% // Head: 87.866% // Increases project coverage by +0.002% 🎉

Coverage data is based on head (bb0e6f3) compared to base (4c14910).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2607       +/-   ##
=============================================
+ Coverage   87.864%   87.866%   +0.002%     
=============================================
  Files           71        71               
  Lines         5356      5357        +1     
  Branches       893       893               
=============================================
+ Hits          4706      4707        +1     
  Misses         471       471               
  Partials       179       179               
Impacted Files Coverage Δ
sanic/mixins/startup.py 91.916% <100.000%> (+0.018%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit aef2673 into main Nov 29, 2022
@ahopkins ahopkins deleted the shutdown-socket branch November 29, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants