Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore name argument on Python 3.7 #2355

Merged
merged 10 commits into from Jan 6, 2022
Merged

Ignore name argument on Python 3.7 #2355

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
18c6709
Ignore name argument on Python 3.7
ahopkins Jan 4, 2022
f0e30b1
Fixed task is created again when adding the task (#2356)
SaidBySolo Jan 5, 2022
458a4ea
Add some unit tests
ahopkins Jan 5, 2022
7f76eda
Merge branch 'task-name-3.7' of github.com:sanic-org/sanic into task-…
ahopkins Jan 5, 2022
eba894d
Update sanic/app.py
ahopkins Jan 6, 2022
7dfb940
Merge branch '21.12LTS' into task-name-3.7
ahopkins Jan 6, 2022
4715e57
Merge branch '21.12LTS' of github.com:sanic-org/sanic into task-name-3.7
ahopkins Jan 6, 2022
71577cc
Merge branch 'task-name-3.7' of github.com:sanic-org/sanic into task-…
ahopkins Jan 6, 2022
8f84ef0
squash
ahopkins Jan 6, 2022
39eecd0
squash
ahopkins Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion sanic/app.py
View file
Open in desktop
Expand Up @@ -1553,7 +1553,15 @@ def _loop_add_task(
register: bool = True,
) -> Task:
prepped = cls._prep_task(task, app, loop)
task = loop.create_task(prepped, name=name)
if sys.version_info == (3, 7):
if name:
error_logger.warning(
"Cannot set a name for a task when using Python 3.7. Your "
"task will be created without a name."
)
task = loop.create_task(prepped)
else:
task = loop.create_task(prepped, name=name)

if name and register:
app._task_registry[name] = task
Expand Down