New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore name argument on Python 3.7 #2355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a test for this?
Sure. If nothing else it will boost our cov % |
f0e30b1
I tend to bring this up every now and then, but this might also be a time to consider dropping Python 3.7 support. Even Debian is at 3.9 and other distros have already moved to 3.10. MacOS ships with 3.8 and Microsoft Store has 3.10. |
We probably will by the end of the year. I see no compelling reason to do it just yet. The place where I see the biggest pain-point is with Sanic Extensions, which is already 3.8+. We do still see about 10-15% of our downloads from 3.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a test to prevent #2356 from happening again in the future?
Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
We need to ignore the
name
argument on Python 3.7