Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sending multiple or mixed responses on a single request #2327

Merged
merged 72 commits into from Dec 9, 2021
Merged

Prevent sending multiple or mixed responses on a single request #2327

merged 72 commits into from Dec 9, 2021

Commits on Nov 26, 2021

  1. Nicer error handling after eof, waning for second res created

    @ChihweiLHBird
    ChihweiLHBird committed Nov 26, 2021
    Copy the full SHA
    ff6972f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Fix type hint

    @ChihweiLHBird
    ChihweiLHBird committed Nov 27, 2021
    Copy the full SHA
    978412a View commit details
    Browse the repository at this point in the history

  2. Prevent second call to request.respond in handler.

    @ChihweiLHBird
    ChihweiLHBird committed Nov 27, 2021
    Copy the full SHA
    7b4cd01 View commit details
    Browse the repository at this point in the history

  3. Move stream state detect logic from http to response

    @ChihweiLHBird
    ChihweiLHBird committed Nov 27, 2021
    Copy the full SHA
    d6e38af View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Update exception handling for prevent second response

    @ChihweiLHBird
    ChihweiLHBird committed Nov 28, 2021
    Copy the full SHA
    584c5bc View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @ChihweiLHBird
    ChihweiLHBird committed Nov 28, 2021
    Copy the full SHA
    7af89ef View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Clean up new test cases

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    f3c9dd6 View commit details
    Browse the repository at this point in the history

  2. handle exception in request.reset_response

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    c79cb8e View commit details
    Browse the repository at this point in the history

  3. More clear exception raising logic in Request.respond

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    7cc05dd View commit details
    Browse the repository at this point in the history

  4. Cleanup and make app doesn't send err page when another res was sent

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    23956ed View commit details
    Browse the repository at this point in the history

  5. Fix test case

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    bc873f1 View commit details
    Browse the repository at this point in the history

  6. Fix

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    25e0eb0 View commit details
    Browse the repository at this point in the history

  7. raise an exception when request.respond is called and another res was… 

    … sent
    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    df9c404 View commit details
    Browse the repository at this point in the history

  8. Remove broken tests

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    08c3eb4 View commit details
    Browse the repository at this point in the history

  9. Undo change

    @ChihweiLHBird
    ChihweiLHBird committed Dec 1, 2021
    Copy the full SHA
    94d8db9 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Create new exception type: ResponseException; fixed msgs

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    8fe123b View commit details
    Browse the repository at this point in the history

  2. Fix msg

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    bb83527 View commit details
    Browse the repository at this point in the history

  3. Only run res middleware when res is new

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    8ee9270 View commit details
    Browse the repository at this point in the history

  4. Update test case

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    b65ee67 View commit details
    Browse the repository at this point in the history

  5. Fix msg

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    83b4aba View commit details
    Browse the repository at this point in the history

  6. Fix msg

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    777e9f6 View commit details
    Browse the repository at this point in the history

  7. Fix re_use_res

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    3dab5fc View commit details
    Browse the repository at this point in the history

  8. Fix test case

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    be9b4cd View commit details
    Browse the repository at this point in the history

  9. Refactor some logiscs; other minor changes

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    153be3c View commit details
    Browse the repository at this point in the history

  10. Fix type checking

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    893d432 View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    8ca425f View commit details
    Browse the repository at this point in the history

  12. Candidate 2 implementation

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    2c40907 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 2, 2021
    Copy the full SHA
    21fab64 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Try adding stage to asgi

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    62c1dcb View commit details
    Browse the repository at this point in the history

  2. Disconnect stream when new res generated (code by @Tronic)

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    1ce2b44 View commit details
    Browse the repository at this point in the history

  3. Fix typing

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    bcae910 View commit details
    Browse the repository at this point in the history

  4. Fix

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    c9eb6f0 View commit details
    Browse the repository at this point in the history

  5. Disconnect stream from response when resetting

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    d43f74b View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary test

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    7a2c684 View commit details
    Browse the repository at this point in the history

  7. Clear raising exception logic

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    fbd4dfd View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    5b8b8bc View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    58b3613 View commit details
    Browse the repository at this point in the history

  10. Fix typing check

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    1
    Copy the full SHA
    e4b53a0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'zhiwei/dev-candidate2' of https://github.com/ChihweiLHB… 

    …ird/sanic into zhiwei/dev-candidate2
    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    c3524d2 View commit details
    Browse the repository at this point in the history

  12. Fix msg, replace ResponseException with ServerError; add exc_info=Tru… 

    …e to logger call
    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    b4bd23a View commit details
    Browse the repository at this point in the history

  13. Simplefied error raising logic

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    214c1ea View commit details
    Browse the repository at this point in the history

  14. Disconnect prev response in agi.respond

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    32b6b98 View commit details
    Browse the repository at this point in the history

  15. Add response attr to ASGIApp, fix typing

    @ChihweiLHBird
    ChihweiLHBird committed Dec 3, 2021
    Copy the full SHA
    69e8c11 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Strean finally be in Stage.IDLE

    @ChihweiLHBird
    ChihweiLHBird committed Dec 4, 2021
    Copy the full SHA
    97b075d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 4, 2021
    Copy the full SHA
    bca4508 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Only set stage to idle when it is in response

    @ChihweiLHBird
    ChihweiLHBird committed Dec 5, 2021
    Copy the full SHA
    8996167 View commit details
    Browse the repository at this point in the history

  2. Match http behavior

    @ChihweiLHBird
    ChihweiLHBird committed Dec 5, 2021
    Copy the full SHA
    8e67b11 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 6, 2021
    Copy the full SHA
    5ecac7e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zhiwei/dev-candidate2

    @ahopkins
    ahopkins committed Dec 6, 2021
    Copy the full SHA
    dd10699 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Add the deprecated warning for exception handler

    @ChihweiLHBird
    ChihweiLHBird committed Dec 7, 2021
    Copy the full SHA
    61d56ee View commit details
    Browse the repository at this point in the history

  2. Log an error if a res returned by a route handler when a pre res was … 

    …sent
    @ChihweiLHBird
    ChihweiLHBird committed Dec 7, 2021
    Copy the full SHA
    74a4377 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 7, 2021
    Copy the full SHA
    ad7c053 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Add a test case and type hints for tests

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    6f5d378 View commit details
    Browse the repository at this point in the history

  2. Update error log messages

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    cab3f68 View commit details
    Browse the repository at this point in the history

  3. Update and add test cases

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    71e69ab View commit details
    Browse the repository at this point in the history

  4. Fix app

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    8be48a2 View commit details
    Browse the repository at this point in the history

  5. Fix typing and better if statement logic

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    19717fc View commit details
    Browse the repository at this point in the history

  6. Add test cases for sending data after eof

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    cb3abfe View commit details
    Browse the repository at this point in the history

  7. Move send after eof case out and tobe a independent case

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    64a12a9 View commit details
    Browse the repository at this point in the history

  8. Update error msg 

    Co-authored-by: Adam Hopkins <adam@amhopkins.com>
    @ChihweiLHBird @ahopkins
    ChihweiLHBird and ahopkins committed Dec 8, 2021
    Copy the full SHA
    37343b2 View commit details
    Browse the repository at this point in the history

  9. Update error msg2 

    Co-authored-by: Adam Hopkins <adam@amhopkins.com>
    @ChihweiLHBird @ahopkins
    ChihweiLHBird and ahopkins committed Dec 8, 2021
    Copy the full SHA
    d391893 View commit details
    Browse the repository at this point in the history

  10. Update error msg3

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    a350547 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'zhiwei/dev-candidate2' of https://github.com/ChihweiLHB… 

    …ird/sanic into zhiwei/dev-candidate2
    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    4a78dc0 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into zhiwei/dev-candidate2

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    ef2c0ec View commit details
    Browse the repository at this point in the history

  13. Update error msg

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    bdd8210 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'zhiwei/dev-candidate2' of https://github.com/ChihweiLHB… 

    …ird/sanic into zhiwei/dev-candidate2
    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    7793a86 View commit details
    Browse the repository at this point in the history

  15. Fix lint

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    0ad8f52 View commit details
    Browse the repository at this point in the history

  16. Update error msgs in tests

    @ChihweiLHBird
    ChihweiLHBird committed Dec 8, 2021
    Copy the full SHA
    61d8ead View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Fix failed tests

    @ChihweiLHBird
    ChihweiLHBird committed Dec 9, 2021
    Copy the full SHA
    c8f2c3e View commit details
    Browse the repository at this point in the history

  2. Make DeprecationWarning to be consistant with main branch

    @ChihweiLHBird
    ChihweiLHBird committed Dec 9, 2021
    Copy the full SHA
    fc673bb View commit details
    Browse the repository at this point in the history

  3. Check request.responded logic updated

    @ChihweiLHBird
    ChihweiLHBird committed Dec 9, 2021
    Copy the full SHA
    430ae12 View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @ChihweiLHBird
    ChihweiLHBird committed Dec 9, 2021
    Copy the full SHA
    49453c7 View commit details
    Browse the repository at this point in the history