Prevent sending multiple or mixed responses on a single request #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
requested changes
Dec 8, 2021
ahopkins
reviewed
Dec 8, 2021
ahopkins
reviewed
Dec 8, 2021
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
…ird/sanic into zhiwei/dev-candidate2
…ird/sanic into zhiwei/dev-candidate2
ahopkins
approved these changes
Dec 9, 2021
This was referenced Dec 9, 2021
ChihweiLHBird
added a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
…c-org#2327) Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR thread was getting long. This is a new implementation includes the logic that prevents second
request.respondcall.Let's summarize what we expect to be done in this PR and work toward that. Also, the future works planned. Sounds good? @Tronic @ahopkins
I think most comments were resolved here, but I may miss some either not sure about the implementation or forget.
Previous PR: #2323