Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1993 Disable registry #1994

Merged
merged 6 commits into from Jan 5, 2021
Merged

#1993 Disable registry #1994

merged 6 commits into from Jan 5, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 5, 2021

Bring #1993 to v20.12

@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited

Codecov Report

Merging #1994 (ae65849) into 20.12LTS (b66fb6f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           20.12LTS    #1994   +/-   ##
=========================================
  Coverage     92.78%   92.79%           
=========================================
  Files            29       29           
  Lines          3259     3262    +3     
  Branches        569      571    +2     
=========================================
+ Hits           3024     3027    +3     
  Misses          159      159           
  Partials         76       76
Impacted Files Coverage Δ
sanic/config.py 100.00% <ø> (ø)
sanic/app.py 96.02% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66fb6f...ae65849. Read the comment docs.

vltr
vltr approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@vltr vltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #1993.

@ahopkins ahopkins merged commit fe3fdc5 into 20.12LTS Jan 5, 2021
ahopkins added a commit that referenced this pull request Jan 7, 2021
@ahopkins
20.12 lts (#1996)
fcdbeb7 
* Bump to v20.12

* Update Changelog

* #1993 Disable registry (#1994)

* Bump to v20.12 (#1987)

* Bump to v20.12

* Update Changelog

* Add disable app registry

* squash

* Create FUNDING.yml (#1995)
@ahopkins ahopkins deleted the disable-registry branch January 11, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vltr vltr vltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahopkins @vltr