Skip to content

Commit

Permalink
#1993 Disable registry (#1994)
Browse files Browse the repository at this point in the history
* Bump to v20.12 (#1987)

* Bump to v20.12

* Update Changelog

* Add disable app registry

* squash

* Create FUNDING.yml (#1995)
  • Loading branch information
ahopkins committed Jan 5, 2021
1 parent b66fb6f commit fe3fdc5
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 1 deletion.
12 changes: 12 additions & 0 deletions .github/FUNDING.yml
@@ -0,0 +1,12 @@
# These are supported funding model platforms

github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
patreon: # Replace with a single Patreon username
open_collective: sanic-org # Replace with a single Open Collective username
ko_fi: # Replace with a single Ko-fi username
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
liberapay: # Replace with a single Liberapay username
issuehunt: # Replace with a single IssueHunt username
otechie: # Replace with a single Otechie username
custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']
7 changes: 6 additions & 1 deletion sanic/app.py
Expand Up @@ -50,6 +50,7 @@ def __init__(
strict_slashes=False,
log_config=None,
configure_logging=True,
register=None,
):

# Get name from previous stack frame
Expand Down Expand Up @@ -88,7 +89,11 @@ def __init__(
# Register alternative method names
self.go_fast = self.run

self.__class__.register_app(self)
if register is not None:
self.config.REGISTER = register

if self.config.REGISTER:
self.__class__.register_app(self)

@property
def loop(self):
Expand Down
1 change: 1 addition & 0 deletions sanic/config.py
Expand Up @@ -40,6 +40,7 @@
"PROXIES_COUNT": None,
"FORWARDED_FOR_HEADER": "X-Forwarded-For",
"FALLBACK_ERROR_FORMAT": "html",
"REGISTER": True,
}


Expand Down
16 changes: 16 additions & 0 deletions tests/test_app.py
Expand Up @@ -3,6 +3,7 @@
import sys

from inspect import isawaitable
from os import environ
from unittest.mock import patch

import pytest
Expand Down Expand Up @@ -290,6 +291,7 @@ def test_app_registry_name_reuse():
with pytest.raises(SanicException):
Sanic("test")
Sanic.test_mode = True
Sanic("test")


def test_app_registry_retrieval():
Expand All @@ -306,3 +308,17 @@ def test_get_app_does_not_exist_force_create():
assert isinstance(
Sanic.get_app("does-not-exist", force_create=True), Sanic
)


def test_app_no_registry():
Sanic("no-register", register=False)
with pytest.raises(SanicException):
Sanic.get_app("no-register")


def test_app_no_registry_env():
environ["SANIC_REGISTER"] = "False"
Sanic("no-register")
with pytest.raises(SanicException):
Sanic.get_app("no-register")
del environ["SANIC_REGISTER"]

0 comments on commit fe3fdc5

Please sign in to comment.