Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] We no longer use aarch64 on artifact filenames #66503

Merged
merged 1 commit into from May 10, 2024
Merged

[3006.x] We no longer use aarch64 on artifact filenames #66503

merged 1 commit into from May 10, 2024

Conversation

s0undt3ch
Copy link
Member

What does this PR do?

See title

What issues does this PR fix or reference?

Fixes #66502

@s0undt3ch s0undt3ch self-assigned this May 10, 2024
@s0undt3ch s0undt3ch requested a review from a team as a code owner May 10, 2024 17:08
@s0undt3ch s0undt3ch requested review from twangboy and removed request for a team May 10, 2024 17:08
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title We no longer use aarch64 on artifact filenames [3006.x] We no longer use aarch64 on artifact filenames May 10, 2024
@s0undt3ch s0undt3ch linked an issue May 10, 2024 that may be closed by this pull request
[3006.x][BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu) #66502
Closed
9 tasks
dmurphy18
dmurphy18 requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blanket replace of aarch64 to arm64 only breaks Redhat family where it is aarch64.
Need to clean it up and an allow for what family is being used Redhat or Debian.

tools/utils/gh.py Show resolved Hide resolved
tools/utils/gh.py Show resolved Hide resolved
@s0undt3ch
Copy link
Member Author

Blanket replace of aarch64 to arm64 only breaks Redhat family where it is aarch64. Need to clean it up and an allow for what family is being used Redhat or Debian.

No. This has nothing to do with Debian or RH packages.
This is about consistency in the pipeline and simplification of the developer experience, not consistency with regards to what the OS chooses.

@s0undt3ch s0undt3ch merged commit 374a960 into saltstack:3006.x May 10, 2024
166 checks passed
@s0undt3ch s0undt3ch deleted the hotfix/3006.x-fixes branch May 10, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmurphy18 dmurphy18 dmurphy18 requested changes

@twangboy twangboy Awaiting requested review from twangboy twangboy is a code owner automatically assigned from saltstack/team-core

Assignees

@s0undt3ch s0undt3ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3006.x][BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu)
2 participants
@s0undt3ch @dmurphy18