Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x][BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu) #66502

Closed
9 tasks
dmurphy18 opened this issue May 10, 2024 · 2 comments · Fixed by #66503
Assignees
Labels
Bug broken, incorrect, or confusing behavior

Comments

@dmurphy18
Copy link
Contributor

Description
The command 'tools ts setup' if it find arm64 in the slug assumes architecture 'aarch64', which is incorrect for Debian family of plaforms.

Setup
Build a Debian family slug for arm64, and then try to use it, get an error salt-*-onedir-linux-aarch64.tar.xz not found, whereas the correct file name is salt-3006.8+28.g662507a99e-onedir-linux-arm64.tar.xz

Please be as specific as possible and give set-up details.

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • VM running on a cloud service, please be explicit and add details
  • container (Kubernetes, Docker, containerd, etc. please specify)
  • or a combination, please be explicit
  • jails if it is FreeBSD
  • classic packaging
  • onedir packaging
  • used bootstrap to install

Steps to Reproduce the behavior

david@david-XPS-15-9570:~/devcode/dgm_salt_3006/salt$ tools ts setup --platform linux --slug ubuntu-22.04-arm64 --pr 65792 --pkg 2>&1 | tee ~/mytest.log
[10:14:47] Consider this in preliminary support. There are most likely things to iron out still.                                                                                                                                                                 
           Discovering the run_id(branch=None, nightly=None, pr=65792, repository='saltstack/salt')                                                                                                                                                              
           Got the GitHub token from the 'gh' CLI tool                                                                                                                                                                                                           
           Searching for workflow runs for HEAD SHA: 3e245920e17bcb1cc19ea5f0590ff99855a659c3                                                                                                                                                                    
[10:14:48] Discovered 1 workflow runs for HEAD SHA 3e245920e17bcb1cc19ea5f0590ff99855a659c3                                                                                                                                                                      
           Discovered run_id: 9021352516                                                                                                                                                                                                                         
           Searching for artifact salt-*-onedir-linux-aarch64.tar.xz from run_id 9021352516 in repository saltstack/salt ...                                                                                                                                     
           Got the GitHub token from the 'gh' CLI tool                                                                                                                                                                                                           
[10:14:49] Failed to find an artifact by the name of 'salt-*-onedir-linux-aarch64.tar.xz'                                                                                                                                                                        
david@david-XPS-15-9570:~/devcode/dgm_salt_3006/salt$

The error logs show name: salt-3006.8+28.g662507a99e-onedir-linux-arm64.tar.xz

Expected behavior
The tools ts setup should be looking for salt-*-onedir-linux-arm64.tar.xz

@dmurphy18 dmurphy18 added Bug broken, incorrect, or confusing behavior needs-triage labels May 10, 2024
@dmurphy18 dmurphy18 self-assigned this May 10, 2024
@dmurphy18 dmurphy18 changed the title [BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu) [3006.x][BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu) May 10, 2024
@dmurphy18 dmurphy18 added this to the Sulfur v3006.9 milestone May 10, 2024
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 10, 2024
@s0undt3ch s0undt3ch linked a pull request May 10, 2024 that will close this issue
@s0undt3ch s0undt3ch self-assigned this May 10, 2024
@s0undt3ch
Copy link
Member

Fix was merged into 3006.x

@dmurphy18
Copy link
Contributor Author

SO rough shod over review , if we no longer use aarch64 on artifacts names, I sure hope this is unaffected https://repo.saltproject.io/salt/py3/redhat/9/aarch64/latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants