Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phil davis issue 588 #628

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Phil davis issue 588 #628

wants to merge 23 commits into from

Commits on Nov 8, 2023

  1. Bump dependencies in composer.json

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    605cee3 View commit details
    Browse the repository at this point in the history

  2. Increase phpstan to level 6

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f0aeaba View commit details
    Browse the repository at this point in the history

  3. Adjust mostly test code for phpstan level 6

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3fe0960 View commit details
    Browse the repository at this point in the history

  4. Declare more types in tests

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    14c482b View commit details
    Browse the repository at this point in the history

  5. Remove useless check of propertyCounters < 1 

    phpstan reports:
 588    Comparison operation "<" between int<1, max> and 1 is always false.

That is correct. The code higher up sets
$propertyCounters[$name] = 1;
and then only ever increments it.
So it can never be less than 1.
    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    96d2b0d View commit details
    Browse the repository at this point in the history

  6. Adjust some type declarations in lib/Component.php

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4fda87f View commit details
    Browse the repository at this point in the history

  7. Remove phpstan-ignore-line from lines that no longer give a phpstan e… 

    …rror
    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e4777ff View commit details
    Browse the repository at this point in the history

  8. Fixup phpstan errors in lib/Component/VEvent.php

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1baf535 View commit details
    Browse the repository at this point in the history

  9. add ATTENDEE to possible magic properties of VEvent

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4aa9c7f View commit details
    Browse the repository at this point in the history

  10. Adjust tests to remove phpstan errors

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d0398cb View commit details
    Browse the repository at this point in the history

  11. Move public string 'name' into Node 

    All of Component, Parameter and Property have 'name'.

Moving it into Node helps phpstan to understand that 'name' always exists.
    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a7745a6 View commit details
    Browse the repository at this point in the history

  12. Add dollar in front of @Property variables

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    0b50fa3 View commit details
    Browse the repository at this point in the history

  13. Fixup phpstan things reported in MainTest

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8d14f74 View commit details
    Browse the repository at this point in the history

  14. Fix cs-style

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2bd8ee5 View commit details
    Browse the repository at this point in the history

  15. Fix things reported by phpstan in tests

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d09fcf3 View commit details
    Browse the repository at this point in the history

  16. Adjust types in lib/Writer.php

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e8d39e6 View commit details
    Browse the repository at this point in the history

  17. Adjust types in lib/VCardConverter.php

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    719bac9 View commit details
    Browse the repository at this point in the history

  18. Call static assert functions with self::

    @phil-davis @DeepDiver1975
    phil-davis authored and DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bf44efb View commit details
    Browse the repository at this point in the history

  19. fix: left over phpstan errors after rebase

    @DeepDiver1975
    DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ef31eff View commit details
    Browse the repository at this point in the history

  20. fix: declare iterator type on class Node + array types in ICalendar

    @DeepDiver1975
    DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bccb315 View commit details
    Browse the repository at this point in the history

  21. fix: cs-fixer

    @DeepDiver1975
    DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4c449ce View commit details
    Browse the repository at this point in the history

  22. ci: add php 8.3

    @DeepDiver1975
    DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8d45cf0 View commit details
    Browse the repository at this point in the history

  23. fix: type declarations when using VCalendar->VEVENT

    @DeepDiver1975
    DeepDiver1975 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6805cf2 View commit details
    Browse the repository at this point in the history