Phil davis issue 588 #628
Open
Phil davis issue 588 #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpstan reports: 588 Comparison operation "<" between int<1, max> and 1 is always false. That is correct. The code higher up sets $propertyCounters[$name] = 1; and then only ever increments it. So it can never be less than 1.
All of Component, Parameter and Property have 'name'. Moving it into Node helps phpstan to understand that 'name' always exists.
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
============================================
- Coverage 98.76% 98.68% -0.08%
+ Complexity 1865 1864 -1
============================================
Files 71 71
Lines 5325 5329 +4
============================================
Hits 5259 5259
- Misses 66 70 +4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
DeepDiver1975
commented
Nov 8, 2023
| @@ -11,6 +11,8 @@ | |||
| * @author Evert Pot (http://evertpot.com/) | |||
| * @license http://sabre.io/license/ Modified BSD License | |||
| */ | |||
|
|
|||
| /** @implements \IteratorAggregate<int, Node> */ | |||
There was a problem hiding this comment.
I am not too sure if this is the correct approach ... it can also hold sub classes of Node .....
There was a problem hiding this comment.
@phil-davis @staabm what do you think?
Any better options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #591