Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.3 compatibility #422

Closed
alecpl opened this issue Sep 21, 2018 · 2 comments
Closed

PHP 7.3 compatibility #422

alecpl opened this issue Sep 21, 2018 · 2 comments

Comments

@alecpl
Copy link
Contributor

alecpl commented Sep 21, 2018 •
edited

First problem PHP Parse error: syntax error, unexpected ':' in /home/alec/repos/vobject/tests/VObject/BirthdayCalendarGeneratorTest.php on line 480

And another one (after I fixed the first):

1) Sabre\VObject\BirthdayCalendarGeneratorTest::testVcardStringWithValidBirthday
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/home/alec/repos/vobject/lib/Component/VCard.php:514
/home/alec/repos/vobject/lib/Parser/MimeDir.php:166
/home/alec/repos/vobject/lib/Parser/MimeDir.php:89
/home/alec/repos/vobject/lib/Reader.php:46
/home/alec/repos/vobject/lib/BirthdayCalendarGenerator.php:73
/home/alec/repos/vobject/tests/VObject/BirthdayCalendarGeneratorTest.php:39

2) Sabre\VObject\FreeBusyGeneratorTest::testGeneratorBaseObject
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/home/alec/repos/vobject/lib/FreeBusyGenerator.php:433
/home/alec/repos/vobject/tests/VObject/FreeBusyGeneratorTest.php:16
alecpl added a commit to alecpl/sabre-vobject that referenced this issue Sep 21, 2018
@alecpl
Fix PHP 7.3 compatibility (sabre-io#422)
b651377
@alecpl
Copy link
Contributor Author

alecpl commented Sep 21, 2018

#423

DeepDiver1975 pushed a commit that referenced this issue Sep 25, 2018
@alecpl @DeepDiver1975
Fix PHP 7.3 compatibility (#422)
85243f5
DeepDiver1975 pushed a commit that referenced this issue Sep 25, 2018
@alecpl @DeepDiver1975
Fix PHP 7.3 compatibility (#422)
2f5f131
DeepDiver1975 pushed a commit that referenced this issue Sep 25, 2018
@alecpl @DeepDiver1975
Fix PHP 7.3 compatibility (#422)
54c3a88
DeepDiver1975 pushed a commit that referenced this issue Sep 25, 2018
@alecpl @DeepDiver1975
Fix PHP 7.3 compatibility (#422)
f3cc955
@alecpl
Copy link
Contributor Author

alecpl commented Sep 26, 2018

Merged.

@alecpl alecpl closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecpl