Update VAlarm.php #370
Open
Update VAlarm.php #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the related property of a VALARM in a VTODO is "START" it should be Related to the DTSTART and this property MUST be present according to spec: https://tools.ietf.org/html/rfc5545#section-3.8.6.3
|
The change is good, but the tests also need to pass |
Throwing an InvalidDataException when adding a VALARM relative to non-existing START
|
The change is good, but the test is bad, the ICS isn't RFC 5545 compliant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the related property of a VALARM in a VTODO is "START" it should be Related to the DTSTART and this property MUST be present according to spec:
https://tools.ietf.org/html/rfc5545#section-3.8.6.3