For a vtodo, a start alarm must refer to dtstart #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the RFC 5545 (https://tools.ietf.org/html/rfc5545#page-74) said: "In an alarm set to trigger on the "START" of an event or to-do, the "DTSTART" property MUST be present in the associated event or to-do." So when related = start, we must use the dtstart of the vtodo, not the due. Since it's the same thing as the vevent, the if isn't needed.
|
woops i didn't see pr #370 sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Like the RFC 5545 (https://tools.ietf.org/html/rfc5545#page-74) said:
"In an alarm set to trigger on the "START" of an event or to-do,
the "DTSTART" property MUST be present in the associated event or
to-do."
So when related = start, we must use the dtstart of the vtodo, not the due. Since it's the same thing as the vevent, the if isn't needed.