fix: Handle Depth header for COPY as this is required by RFC
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `Depth: infinity` is allowed, ref: rfc4918#section-9.9.2 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1. According to the RFC[1] servers **must** support `Depth` 'infinity' and 0. 2. And COPY method on a collection without a Depth header MUST act as if a Depth header with value "infinity" was included. [1] rfc4918#section-9.8.3 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
DeepDiver1975
requested changes
Nov 8, 2023
|
|
||
| // Depth of inifinty is valid for MOVE and COPY. If it is not set the RFC requires to act like it was 'infinity'. | ||
| $depth = strtolower($request->getHeader('Depth') ?? 'infinity'); | ||
| if ($depth !== 'infinity' && is_numeric($depth)) { |
There was a problem hiding this comment.
In core plugin above it is stated that only infinity is allowed. Adding this logic here can reduce the necessary code changes a lot.
There was a problem hiding this comment.
@DeepDiver1975 yes thats for MOVE, but for COPY we need to support also numeric values.
|
ping again, also cc @phil-davis Would be great to get this fixed so sabre passes the litmus test v15 ( https://github.com/notroj/litmus previously http://www.webdav.org/neon/litmus/ ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Sabre\DAV does not support the
Depthheader onCOPYandMOVE.But the RFC4918 requires servers to do so, the header is not required but:
MOVEthe header, if available, must be 'infinity' -> We just have to check the header and throw bad request otherwiseCOPYthe header may 'infinity' or a positive integer including 0So especially the
COPYmethod is currently broken, we noticed this when using the WebDAV litmus test bench (version 0.14) which checks for shallow copies (meaning copy a collection with depth 0).This PR fixes all of this points, while trying to keep backwards compatible. Of cause any using application that implements
ICopyTarget::copyIntois still broken and need to adapt to the depth change (it continues to work as before, but the bug fix does not propagate).Reference from the RFC:
COPYDepth'infinity' and '0': rfc4918#section-9.8.3MOVEonlyDepth: infinityis allowed: rfc4918#section-9.9.2