Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Litmus to 0.15 #39627

Open
provokateurin opened this issue Jul 30, 2023 · 4 comments
Open

Upgrade Litmus to 0.15 #39627

provokateurin opened this issue Jul 30, 2023 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav tests Related to tests

Comments

@provokateurin
Copy link
Member

How to use GitHub

  • Please use the 馃憤 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

Currently we only test against litmus 0.13 which is not the newest version. The latest version contains new checks that uncover some problems in the Nextcloud WebDAV implementation like #39625.

Describe the solution you'd like
Litmus should be upgraded to 0.14 which is the latest version. The development has been happening at https://github.com/notroj/litmus for years and http://www.webdav.org/neon/litmus/ doesn't seem to get updated anymore (or they just forgot it).

@provokateurin provokateurin added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 30, 2023
@provokateurin
Copy link
Member Author

provokateurin commented Jul 30, 2023

The copy_shallow test doesn't pass on litmus 0.14, this might be a problem with our implementation (it is a new test).

@joshtrichards joshtrichards added feature: dav tests Related to tests labels Aug 24, 2023
@susnux
Copy link
Contributor

susnux commented Oct 25, 2023

This is a problem with Sabre\DAV. It implements MOVE and then handles COPY like MOVE but with keeping the origin.
But for WebDAV MOVE may only have the Depth: infinity header set, but COPY may have any Depth and servers MUST implement infinity (which we have) and 0 which fails (see litmus 0.14).

@susnux
Copy link
Contributor

susnux commented Oct 25, 2023

This is an upstream issue, see my PR: sabre-io/dav#1495

@provokateurin
Copy link
Member Author

I don't remember where this was, but the tests only fail on one endpoint and not on the other. Like /remote.php/dav/files works and /remote.php/webdav doesn't (or might be the other way around).

@provokateurin provokateurin changed the title Upgrade Litmus to 0.14 Upgrade Litmus to 0.15 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav tests Related to tests
Projects
None yet
Development

No branches or pull requests

3 participants