Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.0: Re-write for the next version #146

Merged
merged 112 commits into from Jan 5, 2023
Merged

v8.0.0: Re-write for the next version #146

merged 112 commits into from Jan 5, 2023

Conversation

CraZySacX
Copy link
Member

@CraZySacX CraZySacX commented Dec 28, 2022

Release 8.0.0-beta.0 has been published

crates.io
docs.rs

Feel free to comment on this PR about the main goals outline below

  • Minimize the vergen footprint.
    • Adopt an opt-in methodology rather than opt-out.
    • Move from _mut config to a builder pattern.
    • Default features empty
    • Support the ability to configure vergen to emit warnings rather than a hard build error.
  • Minimize the vergen compile time impact.
    • git2 is a large feature, add back support for command line git to help here.
    • Remove extraneous libraries that add fluff over functionality, i.e. thiserror
  • Allow for idempotent output.
    • There have been requests to force vergen output to be reproducible. See Read environment variables to remove impurities #141 for more information on this.
    • Support environment variables like SOURCE_DATE_EPOCH that make reproducible easier.
    • Backport this to v7 and maybe v6?
  • vergen should compile and test from a source tarball
    • A missing .git directory is the current culprit here.
    • Backport this to v7 and maybe v6?

@CraZySacX CraZySacX added this to the v8 milestone Dec 28, 2022
@CraZySacX CraZySacX self-assigned this Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #146 (cec821a) into master (5b66fe5) will increase coverage by 11.67%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           master      #146       +/-   ##
============================================
+ Coverage   88.32%   100.00%   +11.67%     
============================================
  Files          10        10               
  Lines         471       947      +476     
============================================
+ Hits          416       947      +531     
+ Misses         55         0       -55     
Impacted Files Coverage Δ
src/emitter.rs 100.00% <100.00%> (ø)
src/feature/build.rs 100.00% <100.00%> (+12.96%) ⬆️
src/feature/cargo.rs 100.00% <100.00%> (ø)
src/feature/git/cmd.rs 100.00% <100.00%> (ø)
src/feature/git/git2.rs 100.00% <100.00%> (ø)
src/feature/git/gix.rs 100.00% <100.00%> (ø)
src/feature/rustc.rs 100.00% <100.00%> (+11.53%) ⬆️
src/feature/si.rs 100.00% <100.00%> (+5.74%) ⬆️
src/key.rs 100.00% <100.00%> (ø)
src/utils.rs 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kerollmops
Copy link

Kerollmops commented Jan 5, 2023

Hey @CraZySacX,

Thank you very much for vergen we use it in Meilisearch and it works great! However, I was trying to update our dependencies to enum-iterator and was unable to bump to the 1.2.0 one, we are stuck using 1.1.3. Is there a particular reason why you depend on ~1.1.3 and not upgrading to the new version?

Thank you

@CraZySacX
Copy link
Member Author

Hey @CraZySacX,

Thank you very much for vergen we use it in Meilisearch and it works great! However, I was trying to update our dependencies to enum-iterator and was unable to bump to the 1.2.0 one, we are stuck using 1.1.3. Is there a particular reason why you depend on ~1.1.3 and not upgrading to the new version?

Thank you

The original reason was #132. I'll check version 1.2.0 to see if they have removed that nightly only dependency.

@Kerollmops
Copy link

The original reason was #132. I'll check version 1.2.0 to see if they have removed that nightly only dependency.

Ho right! I understand. It has been shipped in stable since 1.63, now.

@CraZySacX
Copy link
Member Author

The original reason was #132. I'll check version 1.2.0 to see if they have removed that nightly only dependency.

Ho right! I understand. It has been shipped in stable since 1.63, now.

Yep, seem good on stable now. I'll push out a new v7 release here shortly.

@CraZySacX
Copy link
Member Author

@Kerollmops I've pushed out 7.5.0. Had to bump the MSRV to 1.63 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants