Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and update dependencies #1

Closed
wants to merge 8 commits into from
Closed

Conversation

yubiuser
Copy link
Owner

@yubiuser yubiuser commented Apr 1, 2023

I used cargo-udeps from here to scan for unused dependencies. Two package were removed num and glob.
With cargo upgrades from here I scanned for upgradable dependencies in the Cagro.toml files. I updated them (and regenerated the Cargo.lock) execept of

librespot-core: /core/Cargo.toml
	base64 matches 0.13.1;	latest is 0.21.0
	quick-xml matches 0.23.1;	latest is 0.28.1
	rsa matches 0.6.1;	latest is 0.8.2
	vergen matches 7.5.1;	latest is 8.1.0

librespot-discovery: /discovery/Cargo.toml
	base64 matches 0.13.1;	latest is 0.21.0

because they require changes to the code beyond my rust knowledge. I tracked them down as far as I could - hopefully someone else can continue here:

  • vergen does not have thevergen::Config structure since 8.0 anymore, but uses vergen::EmitBuilder now.
  • rsa does not have the hash module anymore since 0.7.0, but uses OIDs
  • base64 changed encode* and decode* top level functions to methods of engine since 0.20
  • quick-xml failed with a few compiling errors

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser force-pushed the remove_dependencies branch 2 times, most recently from 196d53f to 0443182 Compare April 1, 2023 10:56
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser force-pushed the remove_dependencies branch 10 times, most recently from 1be0ac9 to e3771e5 Compare April 2, 2023 18:57
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant