Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-support) Differentiate JS docs and TS docs when generating adapters #2956

Merged
merged 1 commit into from Jun 21, 2022

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jun 20, 2022

A bug has been raised in
#2947, which is the
consequence of a bug introduced in
#2909.

This patch fixes it by differentiating JS docs and TS docs
clearly. The Context::push_setter and Context::push_getter methods
now receive a js_docs and a ts_docs, which prevent any confusions.

…apters.

A bug has been raised in
rustwasm#2947, which is the
consequence of a bug introduced in
rustwasm#2909.

This patch fixes it by differentiating JS docs and TS docs
clearly. The `Context::push_setter` and `Context::push_getter` methods
now receive a `js_docs` and a `ts_docs`, which prevent any confusions.
@Hywan
Copy link
Contributor Author

Hywan commented Jun 20, 2022

Fail to build on rustc nightly because:

error: package time v0.3.10 cannot be built because it requires rustc 1.57.0 or newer, while the currently active rustc version is 1.56.0-nightly

because there is:

- run: rustup default nightly-2021-09-02

in some places.

@alexcrichton Which nightly versions are you willing to update to?

@joaofreires
Copy link
Contributor

error: package time v0.3.10 cannot be built because it requires rustc 1.57.0 or newer, while the currently active rustc version is 1.56.0-nightly

Looks like this error is because the crate time launched a new release, tests prior the new version (using the crate time v0.3.9) were working fine.

https://crates.io/crates/time/versions

@alexcrichton
Copy link
Contributor

Updating that nightly is fine to do at any time, it's just pinned to avoid breaking when rust releases a new nightly.

@joaofreires
Copy link
Contributor

@alexcrichton I tested with nightly-2022-05-19 and all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants