Getters and setters are missing jsdoc types in 0.2.81 (not 0.2.80) #2947
Labels
Comments
dsherret
changed the title
Hywan
added a commit
to Hywan/wasm-bindgen
that referenced
this issue
Jun 20, 2022
…apters. A bug has been raised in rustwasm#2947, which is the consequence of a bug introduced in rustwasm#2909. This patch fixes it by differentiating JS docs and TS docs clearly. The `Context::push_setter` and `Context::push_getter` methods now receive a `js_docs` and a `ts_docs`, which prevent any confusions.
alexcrichton
pushed a commit
that referenced
this issue
Jun 21, 2022
…apters. (#2956) A bug has been raised in #2947, which is the consequence of a bug introduced in #2909. This patch fixes it by differentiating JS docs and TS docs clearly. The `Context::push_setter` and `Context::push_getter` methods now receive a `js_docs` and a `ts_docs`, which prevent any confusions.
|
@Hywan yup, it's fixed. Thanks so much for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
In the latest 0.2.81 the .js file is missing jsdoc types on getters and setters. This is because in #2909 they were set to
None: https://github.com/rustwasm/wasm-bindgen/pull/2909/files#diff-072222e984a549efeebf98f26d0c59a69d88abe246db7e0958654fc32471313eR2531Steps to Reproduce
Sorry, I do not have time right now to offer a simple reproduction, but I have pointed out the cause in the code above. Also a fix can be seen here, which is a revert of the above: 387e821 -- but it is probably not a real fix since this was done for some reason in #2909
Expected Behavior
Getters and setters should still have jsdoc comment types when not using TypeScript.
Actual Behavior
The types are missing in 0.2.81
cc @Hywan
The text was updated successfully, but these errors were encountered: