Fix Windows static library detection and usage #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although there's a clear MSVC convention of calling import libraries "xxxx.lib", when a build system creates both static and shared libraries, a race condition will be caused [1]. To this end, the Meson build system decided to also apply the GNU convention for the MSVC ABI [2], which is not considered in pkg-config-rs. [1]: https://aomedia-review.googlesource.com/c/aom/+/173603 [2]: mesonbuild/meson#8153
amyspark
force-pushed
the
fix-windows-library-detection
branch
2 times, most recently
from
e635f4c
to
7c30de6
Compare
sdroege
reviewed
Jan 16, 2024
sdroege
approved these changes
Jan 16, 2024
amyspark
force-pushed
the
fix-windows-library-detection
branch
from
7c30de6
to
aafa1b2
Compare
sdroege
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is intended to address some issues found when attempting to link to static libraries under Windows.
-Wl,--undefinedflags were silently skipped.is_static_availabledoes not consider Windows SDK or CRT bindings..aand.dll.aconvention for MSVC as well, thus letting Meson-built libraries be used.CC @nirbheek