Don't ignore transitive imports when probing a static library

[amyspark]

This is needed towards building GStreamer's Rust plugins statically on Windows.

CC @nirbheek

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a80ea92). Click here to learn what that means.

❗ Current head d3dc609 differs from pull request most recent head a89df41. Consider uploading reports for the commit a89df41 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage        ?   75.14%           
=======================================
  Files           ?        3           
  Lines           ?     3022           
  Branches        ?        0           
=======================================
  Hits            ?     2271           
  Misses          ?      751           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gdesmott]

We stopped relying on pkg-config to print metadata as we do it manually, see 331bab3

Shouldn't we fix that manual code instead then?

[amyspark]

@gdesmott I assume you mean this?

system-deps/src/lib.rs

Line 152 in 331bab3

// TODO: add support for "rustc-link-lib=static=" ?

If so, I'll see what I can do.

[amyspark]

@gdesmott I found the code, it needs a copy of rust-lang/pkg-config-rs#154 applied. Let me know if this looks OK now.

[amyspark]

@gdesmott Hi again, just updated the PR. Could this be reviewed now?

[gdesmott]

The change seems safe enough now.

Which actual use case is it fixing? Did you check it build and is usable now?

[sdroege]

FWIW the pkg-config-rs change that does basically the same is merged and released

[gdesmott]

@amyspark : sorry I missed your latest update.

Can you please rebase on top of main (I just fixed the CI) so we can merge this?

[amyspark]

@gdesmott done, let me know if anything else's needed.

[gdesmott]

Released in 6.2.1, sorry for the delay.