Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow-up on #2963, changing MSG* constant types for musl/emscripten. #2978

Merged
merged 1 commit into from Oct 25, 2022
Merged

follow-up on #2963, changing MSG* constant types for musl/emscripten. #2978

merged 1 commit into from Oct 25, 2022

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Could you just remove the deprecation attrs? We have to figure out how we deliver breaking changes first.

@thomcc
Copy link
Member

thomcc commented Oct 24, 2022

Yeah, deprecations here cause failures when used in the stdlib...

@thomcc
Copy link
Member

thomcc commented Oct 25, 2022

I started a discussion about this in https://rust-lang.zulipchat.com/#narrow/stream/351149-t-libs.2Fcrates/topic/Deprecations.2Ftype.20changes.20in.20.60libc.60.20.28for.20musl.2C.20emscripten.29.

It's tricky because these aren't really being removed, just changed -- We also still need them both before and after in the stdlib (and I'm sure this is true for others too). So, I'm not sure the policy in the CONTRIBUTING.md guide is actually good for cases like this (it seems really geared for removals...)

@thomcc thomcc mentioned this pull request Oct 25, 2022
Merged
@devnexen devnexen force-pushed the musl_emscripten_msg_constants branch from 06c4c40 to 1a5f49f Compare October 25, 2022 05:41
@devnexen devnexen force-pushed the musl_emscripten_msg_constants branch from 1a5f49f to 4ba884a Compare October 25, 2022 05:42
JohnTitor
JohnTitor approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove deprecations on 0.2 first. We can discuss how we treat breaking changes later.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 25, 2022

📌 Commit 4ba884a has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 25, 2022

⌛ Testing commit 4ba884a with merge 3cdabff...

@bors
Copy link
Contributor

bors commented Oct 25, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 3cdabff to master...

@bors bors merged commit 3cdabff into rust-lang:master Oct 25, 2022
@AaronErhardt AaronErhardt mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devnexen @rust-highfive @JohnTitor @thomcc @bors