Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new clippy lints #816

Merged
merged 3 commits into from Oct 27, 2022
Merged

Fix new clippy lints #816

merged 3 commits into from Oct 27, 2022

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@GuillaumeGomez
Copy link
Member Author

New warning is wild:

error: use of deprecated constant `libc::MSG_OOB`: recvmmsg call expects an unsigned type on musl/emscripten
  --> gio/sys/src/manual.rs:32:64
   |
32 |     pub const G_SOCKET_MSG_OOB: super::GSocketMsgFlags = libc::MSG_OOB;
   |                                                                ^^^^^^^
   |
   = note: `-D deprecated` implied by `-D warnings`

Any idea what's going on?

@AaronErhardt
Copy link
Contributor

@GuillaumeGomez looks like a bunch of glibc types were deprecated with no real alternative in place yet (so this has nothing to do with clippy actually). It seems like this got reverted already: rust-lang/libc#2978

@GuillaumeGomez
Copy link
Member Author

Thanks for the information @AaronErhardt !

@sdroege
Copy link
Member

sdroege commented Oct 26, 2022

Yeah, let's not worry about those for now.

gio/src/lib.rs Outdated Show resolved Hide resolved
gio/src/list_model.rs Outdated Show resolved Hide resolved
glib/src/lib.rs Outdated Show resolved Hide resolved
pangocairo/src/lib.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

Updated!

@sdroege sdroege merged commit cc7a2b1 into gtk-rs:master Oct 27, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-lints branch October 27, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants