Implement DedupBy in terms of Coalesce #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
reviewed
May 19, 2020
Serves as base for Coalesce, will serve as base for Dedup et al.
Required for Dedup(By)WithCount.
|
Thanks! bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2020
450: Introduce module coalesce r=jswrenn a=phimuemue Hi! As #440 (thanks for reviewing and merging, btw) presumably conflicts with any existing PRs touching `coalesce` et al, I thought we could just as well seize the opportunity and move these types into an own module (so to speak as a starting point for the problem mentioned in #423 (comment)). I cut-pasted `Coalesce` et al into an own module, rearranged the code so that specialized types follow their generic variants, and ran `cargo fmt` on the new module. I suggest to import the `coalesce` types into `adaptors` similarly to what we already have for `multi_product`. Co-authored-by: philipp <descpl@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the discussion of #423 (comment), we found that
DedupBy/DedupByWithCountcould actually be implemented in terms ofCoalesce. This simplifies the implementation quite a bit and lets derived adaptors inherit specializations.foldonCoalesceso that all the adaptors derived from it inherit the specialization (currently, onlyDedupByhas this specialization).CoalescePredicate(similar toDedupPredicate) to allow for different customizations ofCoalesce.CoalesceBy: Base forCoalesce,DedupBy,DedupByWithCount.DedupBy/DedupByWithCountin terms ofCoalesceBy(using particularimpls).CoalesceCoreis not needed anymore.