Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce module coalesce #450

Merged
merged 1 commit into from Jul 17, 2020
Merged

Conversation

phimuemue
Copy link
Member

Hi! As #440 (thanks for reviewing and merging, btw) presumably conflicts with any existing PRs touching coalesce et al, I thought we could just as well seize the opportunity and move these types into an own module (so to speak as a starting point for the problem mentioned in #423 (comment)).

I cut-pasted Coalesce et al into an own module, rearranged the code so that specialized types follow their generic variants, and ran cargo fmt on the new module.

I suggest to import the coalesce types into adaptors similarly to what we already have for multi_product.

* Cut-paste Coalesce and derived adaptors into own module
* Run cargo fmt on new module
@jswrenn
Copy link
Member

jswrenn commented Jul 17, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 17, 2020

Build succeeded:

@bors bors bot merged commit 96539ff into rust-itertools:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants