Upgrade bitcoin hashes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'd like to get #474 (and a minor version bump) out first. |
|
No sweat, I'll split the version bump out of this and put up a tracking PR separately. |
tcharding
force-pushed
the
07-19-upgrade-bitcoin-hashes
branch
from
c7474d7
to
4f2be0f
Compare
|
Could you put the version bump back in? I'm not sure what your intention here was. |
The manifest has two cases of leading whitespace, doesn't obviously mean anything, remove them. Whitespace was introduced in commit: `7d3a149ca5064147229db147359638cbcb54acdd`
New version of `bitcoin_hashes` is out, lets use it.
We have updated the `bitcoin_hashes` version, this requires a minor version bump and release.
tcharding
force-pushed
the
07-19-upgrade-bitcoin-hashes
branch
from
4f2be0f
to
d31bbc1
Compare
|
Done, I didn't realize we would do the 0.23.4 release and then do the 0.24.0, I thought we would roll both changes into a single release. |
My understanding is that we want to make sure that all major revisions have bugs fixed. Users should not have to upgrade the major version for some bugfix. |
apoelstra
approved these changes
Jul 19, 2022
|
tagged, signed and published |
|
Like a boss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have updated the
bitcoin_hashesversion, this requires a minor version bump and release.bitcoin_hashesdependency