Tracking PR for release v0.24.0 #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest has two cases of leading whitespace, doesn't obviously mean anything, remove them. Whitespace was introduced in commit: `7d3a149ca5064147229db147359638cbcb54acdd`
New version of `bitcoin_hashes` is out, lets use it.
We have updated the `bitcoin_hashes` version, this requires a minor version bump and release.
tcharding
changed the title
|
Yes, point release is nice but maybe we should put notice somewhere that we encourage people to upgrade to 0.24 since the breaking change only affects |
|
I think people will want to use whatever version of this is used by rust-bitcoin. |
|
Closing because I was mistaken in how things would be done. The 0.24.0 bump is back in #475 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs still to merge before release
Todos
Question: Do we want the version bump to 0.23.4 in #474 still?
This PR is tested by a rust-bitcoin build: rust-bitcoin/rust-bitcoin#1103