Derive Hash on a bunch of types #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
derive-hash
branch
2 times, most recently
from
d468a91
to
c4f9419
Compare
tcharding
force-pushed
the
derive-hash
branch
3 times, most recently
from
c401c12
to
76e63a0
Compare
Kixunil
reviewed
Jul 14, 2022
src/util/key.rs
Outdated
| @@ -235,7 +235,7 @@ impl FromStr for PublicKey { | |||
| } | |||
|
|
|||
| /// A Bitcoin ECDSA private key | |||
| #[derive(Copy, Clone, PartialEq, Eq)] | |||
| #[derive(Copy, Clone, PartialEq, Eq, Hash)] | |||
There was a problem hiding this comment.
This is dangerous, see rust-bitcoin/rust-secp256k1#471
src/util/bip32.rs
Outdated
| @@ -45,7 +45,7 @@ impl_array_newtype!(Fingerprint, u8, 4); | |||
| impl_bytes_newtype!(Fingerprint, 4); | |||
|
|
|||
| /// Extended private key | |||
| #[derive(Copy, Clone, PartialEq, Eq)] | |||
| #[derive(Copy, Clone, PartialEq, Eq, Hash)] | |||
In preparation for being able to derive `Hash` on all types in `miniscript`, derive `Hash` on all of the required types.
|
I'd ACK this, why is it a draft? |
|
Was waiting for CI run to finish before taking off draft and forgot about it. |
Kixunil
added
enhancement
trivial
apoelstra
approved these changes
Jul 17, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
ef7fef0 Derive Hash on a bunch of types (Tobin C. Harding) Pull request description: In preparation for being able to derive `Hash` on all types in `miniscript`, derive `Hash` on all of the required types. This PR includes all the changes in https://github.com/rust-bitcoin/rust-bitcoin/pull/933/files and hence supersedes it. ref: rust-bitcoin/rust-miniscript#226 ACKs for top commit: Kixunil: ACK ef7fef0 apoelstra: ACK ef7fef0 Tree-SHA512: 1a1db8b4df2ea8f9e176434bb6fdee5b96f47dcdc6395ebc59e5f5ac5eb13a66fb61e1d90cdbbf12a027f7685fdff21060338c5f27b9d9bf5e9fee452c7c7e83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for being able to derive
Hashon all types inminiscript, deriveHashon all of the required types.This PR includes all the changes in https://github.com/rust-bitcoin/rust-bitcoin/pull/933/files and hence supersedes it.
ref: rust-bitcoin/rust-miniscript#226