Derive hash #394
Closed
Derive hash #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
derive-hash
branch
from
23e5946
to
5db18c5
Compare
Derive hash for all types that currently can. It is not immediately apparent why we have types that do not derive `Debug`, this patch however explicitly does not change this. Fix: rust-bitcoin#394
|
Done in #659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive
Hashfor all structs and enums (excl. error enums) that can.Patch 2 is 'wip' because I'm not sure if it makes sense to derive
Hashfor the types in that patch but the issue says "do all of them"?Draft still for feedback on patch 2. Also I did not re-check the whole codebase, the original PR was done a long time ago, well check it over before taking off draft.
Resolves: #226