Return BlockHash from BlockHeader::validate_pow #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating a block's proof-of-work involves computing the block hash. Returning it from BlockHeader::validate_pow avoids having callers recompute the block hash if it is needed.
TheBlueMatt
approved these changes
Feb 18, 2021
darosior
approved these changes
Feb 18, 2021
sgeisler
added
the
API break
sgeisler
approved these changes
Feb 18, 2021
|
Based on current master and two acks. Merging. |
Merged
dunxen
added a commit
to dunxen/rust-lightning
that referenced
this pull request
Jul 22, 2022
The validate_pow() method now returns the BlockHash since rust-bitcoin v0.26.2 thanks to jkczyz's PR (rust-bitcoin/rust-bitcoin/pull/572).
dunxen
added a commit
to dunxen/rust-lightning
that referenced
this pull request
Jul 22, 2022
The `validate_pow()` method now returns the BlockHash since rust-bitcoin v0.26.2 thanks to jkczyz's PR (rust-bitcoin/rust-bitcoin/pull/572).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating a block's proof-of-work involves computing the block hash. Returning it from
BlockHeader::validate_powavoids having callers recompute the block hash if it is needed.Helpful when validating the chain in lightningdevkit/rust-lightning#791 (comment)