Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse BlockHash from validate_pow() #1627

Merged

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Jul 22, 2022

The validate_pow() method now returns the BlockHash since rust-bitcoin
v0.26.2 thanks to jkczyz's PR (rust-bitcoin/rust-bitcoin/pull/572).

The `validate_pow()` method now returns the BlockHash since rust-bitcoin
v0.26.2 thanks to jkczyz's PR (rust-bitcoin/rust-bitcoin/pull/572).
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #1627 (e256b34) into main (834fe63) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   90.80%   90.79%   -0.02%     
==========================================
  Files          80       80              
  Lines       44654    44654              
  Branches    44654    44654              
==========================================
- Hits        40550    40545       -5     
- Misses       4104     4109       +5     
Impacted Files Coverage Δ
lightning-block-sync/src/poll.rs 87.50% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.09%) ⬇️
lightning/src/util/events.rs 39.54% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834fe63...e256b34. Read the comment docs.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@TheBlueMatt TheBlueMatt merged commit f26e854 into lightningdevkit:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants