Use new error convention introduced in secp #1971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
changed the title
In preparation for splitting the error code out of the `key` module move the module to a subdirectory. Code move / file creation only, no logic changes.
Move the error code out of `key/mod.rs` and into `key/error.rs`. Code move / file creation only, no logic changes.
tcharding
force-pushed
the
08-02-key-errors
branch
from
dadb5ba
to
9bbfaee
Compare
We are changing the way we handle errors to use more specific error types instead of general per-module errors. Make a start on using the new specific error types from secp.
tcharding
force-pushed
the
08-02-key-errors
branch
from
9bbfaee
to
9d93d8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #1956
Draft because:
Uses new, still-in-design error conventions from secp. Just does the error returns in the
crypto/keymodule.