Add segwit API #120
Merged
Add segwit API #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
08-02-segwit-api
branch
2 times, most recently
from
4a50ff2
to
db7144e
Compare
tcharding
force-pushed
the
08-02-segwit-api
branch
2 times, most recently
from
3c7e229
to
d45699f
Compare
|
Hey @apoelstra check this out, its so-hot-right-now :) |
|
Nice! d45699f looks pretty good. I have some nits about the comments, mainly. Think this can be undrafted. |
|
Cool, I'll go over it again today (after I fix the uppercase QR code thing) and undraft. Want to put this in before the alpha release? |
|
Yeah, let's get it in before alpha. We're pretty close. |
tcharding
force-pushed
the
08-02-segwit-api
branch
from
d45699f
to
004261a
Compare
tcharding
force-pushed
the
08-02-segwit-api
branch
from
004261a
to
047a29e
Compare
Merged
apoelstra
reviewed
Aug 7, 2023
apoelstra
reviewed
Aug 7, 2023
apoelstra
reviewed
Aug 7, 2023
apoelstra
reviewed
Aug 7, 2023
apoelstra
reviewed
Aug 7, 2023
Add a segwit API with the aim that "typical" modern bitcoin usage is easy and correct.
tcharding
force-pushed
the
08-02-segwit-api
branch
from
047a29e
to
6c1379b
Compare
apoelstra
approved these changes
Aug 8, 2023
clarkmoody
reviewed
Aug 15, 2023
clarkmoody
reviewed
Aug 15, 2023
|
Thanks for the review @clarkmoody! |
tcharding
force-pushed
the
08-02-segwit-api
branch
from
d79984d
to
bcc8506
Compare
clarkmoody
reviewed
Aug 15, 2023
src/segwit.rs
Outdated
Comment on lines
104
to
110
| encode(hrp, segwit::VERSION_0, witness_program) | ||
| } | ||
|
|
||
| /// Encodes a segwit version 1 address. | ||
| #[cfg(feature = "alloc")] | ||
| pub fn encode_v1(hrp: &Hrp, witness_program: &[u8]) -> Result<String, EncodeError> { | ||
| encode(hrp, segwit::VERSION_1, witness_program) |
There was a problem hiding this comment.
No need for segwit:: scoping here.
There was a problem hiding this comment.
I umm'ed and ahhh'ed about that line, whether the "segwit" added anything, will remove.
Add two field element consts for segwit version 0 an version 1. This makes reading the code much easier since one does not have to remember p ad q.
tcharding
force-pushed
the
08-02-segwit-api
branch
from
bcc8506
to
024ed01
Compare
apoelstra
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
segwitAPI with the aim that "typical" modern bitcoin usage is easy and correct.Done in a separate module so as not to impact the main crate API.