Add timestream support #1918

johansmitsnl · 2021-03-15T15:43:50Z

See PR #1857 which I used as a base platform.

Todo's:

Discover endpoint
More intensive testing (it works in my use case)

tiratatp · 2021-04-06T22:34:55Z

integration_tests/Cargo.toml

+[dependencies.rusoto_timestream_query]
+optional = true
+path = "../rusoto/services/timestream-query"


You need to add timestream-write here too?

johansmitsnl · 2021-04-27T12:50:03Z

integration_tests/Cargo.toml

@@ -805,6 +809,7 @@ all = [
 	"sts",
 	"support",
 	"swf",
+	"timestream-query",


tiratatp · 2021-04-06T22:37:22Z

rusoto/services/timestream-query/src/custom/mod.rs

+        input: QueryRequest,
+    ) -> Result<QueryResponse, RusotoError<QueryError>> {
+        self.update_endpoint().await.map_err(|e| match e {
+            // Remap any DescribeEndpointError to WriteRecordErrors


Wrong comment

tiratatp · 2021-04-06T22:37:39Z

rusoto/services/timestream-query/src/custom/mod.rs

+        input: CancelQueryRequest,
+    ) -> Result<CancelQueryResponse, RusotoError<CancelQueryError>> {
+        self.update_endpoint().await.map_err(|e| match e {
+            // Remap any DescribeEndpointError to WriteRecordErrors


Wrong comment

johansmitsnl · 2021-04-27T12:50:03Z

integration_tests/Cargo.toml

@@ -805,6 +809,7 @@ all = [
 	"sts",
 	"support",
 	"swf",
+	"timestream-query",


johansmitsnl · 2021-04-27T12:51:00Z

@tiratatp I just pushed a new version with the changes you requested. It is partially the PR from #1857 so it is not all my code.

tiratatp

LGTM but I haven't tested it though. Could you explain a bit how you test this?

lasartej · 2021-04-27T19:51:10Z

rusoto/services/timestream-query/src/custom/mod.rs

+        &mut self,
+        input: QueryRequest,
+    ) -> Result<QueryResponse, RusotoError<QueryError>> {
+        self.update_endpoint().await.map_err(|e| match e {


may be misunderstanding this, but does this mean we update the endpoint every time we do a call?

Yes, this is due to the endpoints for queries are dynamic. The same for the writer. Also see here service.json of boto

Yes, the endpoints are dynamic -- but they are meant to be cached for the TTL that comes with them (i.e point 3 here:https://docs.aws.amazon.com/timestream/latest/developerguide/Using-API.endpoint-discovery.describe-endpoints.implementation.html). On a second pass though, we don't actually update the endpoint with each call, only when we find at the time of calling that the expiry for the endpoint has passed. Which seems correct.

So this is ok then?

johansmitsnl · 2021-04-28T19:54:57Z

@tiratatp I'm using it in my own project, I just use the writer part but since I only updated the code to the 0.46 version I assume the other authors who also made the PR for the other parts are using (or did) as well.

I just pushed a new commit since I did some better digging into the code and also generated the new files and tested some more bits.

johansmitsnl · 2021-05-10T18:42:40Z

@tiratatp do you need input from my side or are you just busy?

tiratatp · 2021-05-10T19:06:11Z

@tiratatp do you need input from my side or are you just busy?

I don't have a write request to this repo. The code looks good to me though.

johansmitsnl · 2021-06-03T18:13:31Z

@tiratatp @lasartej is there input needed from my side or is this good for merging?

tiratatp

LGTM

agrinman · 2021-08-01T14:57:04Z

Hi, is there any work/review need before merging? Happy to help if there is. Thanks!

…Note, I had to skip the Timestream query service as it fails to compile due to recursive types in the generated code.

…ommended by AWS.

johansmitsnl · 2021-08-29T08:59:19Z

Rebased on the new master.

nevins-b · 2021-09-03T17:40:27Z

@johansmitsnl thanks for this! It looks like you rebased and bumped rusoto_core to 0.47 but timestream still depends on 0.46.

johansmitsnl · 2021-09-04T07:48:38Z

@nevins-b I have just updated the version and depends. Hope this can get merged soon.

johansmitsnl mentioned this pull request Mar 15, 2021

Add support for Amazon Timestream Write API #1857

Open

tiratatp suggested changes Apr 6, 2021

View reviewed changes

johansmitsnl commented Apr 27, 2021

View reviewed changes

integration_tests/Cargo.toml

@@ -805,6 +809,7 @@ all = [

"sts",

"support",

"swf",

"timestream-query",

Copy link

Author

johansmitsnl Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

tiratatp approved these changes Apr 27, 2021

View reviewed changes

lasartej reviewed Apr 27, 2021

View reviewed changes

tiratatp approved these changes Jun 3, 2021

View reviewed changes

alex-berger and others added 10 commits August 29, 2021 10:57

Add Amazon Timestream write service crate rusoto_timestream_write. …

9267da4

…Note, I had to skip the Timestream query service as it fails to compile due to recursive types in the generated code.

Add endpoint discovery enabled write client TimestreamProducer as rec…

dc8b6ea

…ommended by AWS.

Add Amazon Timestream Query service

148665c

Added Amazon Timestream Query integration tests

66cceda

Added endpoint-discovery-aware Timestream Query client

609de5a

Bump depends that are used in 0.46

f93b55a

The endpoint needs to be discovered but for now hardcode it

64c55b7

Add rusoto_timestream_write to the cargo toml

61836f4

Update comments

6b7486b

Update services json and generated modules

76694c1

johansmitsnl force-pushed the master branch from b91f05c to 76694c1 Compare August 29, 2021 08:58

Bump version and depends to 0.47.0

a894024

pranavmanivannan approved these changes Nov 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timestream support #1918

Add timestream support #1918

johansmitsnl commented Mar 15, 2021 •

edited

tiratatp Apr 6, 2021

johansmitsnl Apr 27, 2021

johansmitsnl Apr 27, 2021

tiratatp Apr 6, 2021

johansmitsnl Apr 27, 2021

tiratatp Apr 6, 2021

johansmitsnl Apr 27, 2021

johansmitsnl Apr 27, 2021

johansmitsnl commented Apr 27, 2021

tiratatp left a comment

lasartej Apr 27, 2021

johansmitsnl Apr 28, 2021

lasartej Apr 28, 2021

johansmitsnl Apr 29, 2021

johansmitsnl commented Apr 28, 2021

johansmitsnl commented May 10, 2021

tiratatp commented May 10, 2021

johansmitsnl commented Jun 3, 2021

tiratatp left a comment

agrinman commented Aug 1, 2021

johansmitsnl commented Aug 29, 2021

nevins-b commented Sep 3, 2021

johansmitsnl commented Sep 4, 2021

Add timestream support #1918

Are you sure you want to change the base?

Add timestream support #1918

Conversation

johansmitsnl commented Mar 15, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johansmitsnl commented Apr 27, 2021

tiratatp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johansmitsnl commented Apr 28, 2021

johansmitsnl commented May 10, 2021

tiratatp commented May 10, 2021

johansmitsnl commented Jun 3, 2021

tiratatp left a comment

Choose a reason for hiding this comment

agrinman commented Aug 1, 2021

johansmitsnl commented Aug 29, 2021

nevins-b commented Sep 3, 2021

johansmitsnl commented Sep 4, 2021

johansmitsnl commented Mar 15, 2021 •

edited