Add support for Amazon Timestream Write API #1857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout this fix newest botocore service code did not compile for "json" and "rest-json" protocol based services with timestamp headers as it correctly generated f64 fields in the structs, but tried to parse them as String.
…Note, I had to skip the Timestream query service as it fails to compile due to recursive types in the generated code.
…Why are those single space characters in the generated code as generated on the test system but not in the one generated on my machine. I am using the same version for Rust stable and rustfmt as the test does (rustfmt 1.4.20-stable (48f6c32e 2020-08-09)).
Rollup Timestream Query API support into existing PR
|
Any chance that this PR will get accepted? |
|
I have opened up a new PR #1918 that is based on the 0.46 release with new Tokio support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Amazon Timestream Write API enabling rusoto clients to write metrics data to Amazon Timestream and to manage Amazon Timestream databases and tables. In order to add Timestream service I also had to bump
botocoreto version 1.19.12.Note, I failed to also add support for Amazon Timestream Query API, because that API's generated code will not compile due to recursive types.