Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry. #423

Merged
merged 4 commits into from Dec 15, 2019
Merged

Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry. #423

merged 4 commits into from Dec 15, 2019

Commits on Oct 31, 2019

  1. A test to ensure find/get entry calls agree.

    @hainesr
    hainesr committed Oct 31, 2019
    Copy the full SHA
    cef3bc0 View commit details
    Browse the repository at this point in the history

  2. Set the default options in Entry the same as File.

    @hainesr
    hainesr committed Oct 31, 2019
    Copy the full SHA
    0f6ca04 View commit details
    Browse the repository at this point in the history

  3. Ensure File#get/find_entry work consistently. 

    I have switched around the logic somewhat so that `get_entry` calls
`find_entry` and raises an exception if it gets `nil` back.
    @hainesr
    hainesr committed Oct 31, 2019
    Copy the full SHA
    2d6b6e0 View commit details
    Browse the repository at this point in the history

  4. Add tests for File#get/find_entry.

    @hainesr
    hainesr committed Oct 31, 2019
    Copy the full SHA
    f3a2f4a View commit details
    Browse the repository at this point in the history