Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry.
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have switched around the logic somewhat so that `get_entry` calls `find_entry` and raises an exception if it gets `nil` back.
|
(I looked back in the blame, and it seems like this inconsistency has always been here, but I don't see any rationale for the current behavior.) |
jdleesmiller
added a commit
that referenced
this pull request
Dec 15, 2019
This was referenced Mar 11, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #422 for a detailed explanation of what is going on here.
This is the quick fix to ensure things are consistent for now. I will work up a PR with a longer term fix once we've decided what to do about it.