Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded files from release build #281

Merged
merged 3 commits into from
May 27, 2023

Conversation

tisba
Copy link
Collaborator

@tisba tisba commented May 27, 2023

I noticed that we include .github/ and bin/ when building. And other things :)

I think we can simplify this, by only including what we need, which is lib/**/* and ext/**/*. Additionally we probably want to continue to pack README, license, changelog and CoC.

before (released 0.6.4)

.
├── CHANGELOG
├── CODE_OF_CONDUCT.md
├── Dockerfile
├── Gemfile
├── LICENSE.txt
├── README.md
├── Rakefile
├── bin
│   ├── console
│   └── setup
├── ext
│   ├── mini_racer_extension
│   │   ├── Makefile
│   │   ├── extconf.rb
│   │   └── mini_racer_extension.cc
│   └── mini_racer_loader
│       ├── Makefile
│       ├── extconf.rb
│       └── mini_racer_loader.c
├── lib
│   ├── mini_racer
│   │   ├── truffleruby.rb
│   │   └── version.rb
│   ├── mini_racer.rb
│   ├── mini_racer_extension.bundle
│   └── mini_racer_loader.bundle
└── mini_racer.gemspec

after (build from master):

.
├── CHANGELOG
├── CODE_OF_CONDUCT.md
├── LICENSE.txt
├── README.md
├── ext
│   ├── mini_racer_extension
│   │   ├── Makefile
│   │   ├── extconf.rb
│   │   └── mini_racer_extension.cc
│   └── mini_racer_loader
│       ├── Makefile
│       ├── extconf.rb
│       └── mini_racer_loader.c
└── lib
    ├── mini_racer
    │   ├── truffleruby.rb
    │   └── version.rb
    ├── mini_racer.rb
    ├── mini_racer_extension.bundle
    └── mini_racer_loader.bundle

@lloeki
Copy link
Collaborator

lloeki commented May 27, 2023

Looks sensible, thanks @tisba !

@lloeki lloeki merged commit 2db9b00 into rubyjs:master May 27, 2023
21 checks passed
@tisba tisba deleted the exclude-dot-github-bin branch June 2, 2023 06:25
SamSaffron pushed a commit that referenced this pull request Jun 5, 2023
* uses FileList and exclude *.bundle and C code

* back to Dir#[] + reject

* don't exclude *.cc? files

* only includes .rb files from lib/

* adds all compilation artefacts to CLEAN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants