Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec: Exclude *.bundle (follow-up #281) #285

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

tisba
Copy link
Collaborator

@tisba tisba commented Jun 2, 2023

Follow-Up for #281
Addresses #283 (comment)

I don't quite fully understand why this breaks, but building locally using bundle exec rake compile broke with #281. It works fine in CI though, which might be worth investigating. What worked for me to fix this (please have a look @Fayti1703) is to make sure *.bundle files are excluded. With this bundle install && bundle exec rake works (compiles and runs tests).

My experience with native extensions is limited. I'd appreciate hints how to make local compilation consistent with CI.

-cc @Fayti1703
-cc @lloeki

@Fayti1703
Copy link
Contributor

I've done some tests on my end... interestingly I see no change in behavior with the commits on this branch.
However, I have noticed that the problem doesn't even occur on a clean clone, which might explain why CI doesn't run into it.

@Fayti1703
Copy link
Contributor

Oh, this is interesting: Checking Gemfile.lock, my clean clone ends up with "PLATFORMS: x86_64-linux"1, where-as the existing worktree has a "PLATFORMS: ruby"1 declaration.

Can you verify if this is similar on your end?

Footnotes

  1. In the original file, these are separated by newline + indentation. I've elected to replace this with a colon for readability. 2

mini_racer.gemspec Outdated Show resolved Hide resolved
@tisba tisba changed the title gemspec: Exclude *.bundle and C code (follow-up #281) gemspec: Exclude *.bundle (follow-up #281) Jun 3, 2023
@tisba
Copy link
Collaborator Author

tisba commented Jun 3, 2023

I've done some tests on my end... interestingly I see no change in behavior with the commits on this branch.
However, I have noticed that the problem doesn't even occur on a clean clone, which might explain why CI doesn't run into it.

I think that the clean & clobber tasks were not properly cleaning up everything. I added {ext,lib}/**/*.{o,so,bundle} and pkg to CLEAN so that with rake clean clobber you should get a clean environment again. I did some testing locally and it looks like a fresh clone. I think that should help somewhat.

@tisba
Copy link
Collaborator Author

tisba commented Jun 3, 2023

Oh, this is interesting: Checking Gemfile.lock, my clean clone ends up with "PLATFORMS: x86_64-linux"1, where-as the existing worktree has a "PLATFORMS: ruby"1 declaration.

Can you verify if this is similar on your end?

Footnotes

  1. In the original file, these are separated by newline + indentation. I've elected to replace this with a colon for readability. ↩2

Not sure I follow 100%: For me it's always PLATFORM: arm64-darwin-22 in Gemfile.lock when it's generated.

@tisba tisba mentioned this pull request Jun 3, 2023
@SamSaffron
Copy link
Collaborator

this is great, thanks.

@SamSaffron SamSaffron merged commit c7ed672 into rubyjs:main Jun 5, 2023
21 checks passed
@tisba tisba deleted the fix-gemspec-exclude branch June 5, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants