Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if RubyGems version explicitly set in gemspec does not match running version #7460

Merged
merged 1 commit into from May 3, 2024

Commits on May 3, 2024

  1. Remove Gem::Specification#mark_version

    This gets in the middle if we ever start allowing to build as if using a
    different RubyGems version than the one being run.
    
    This could be useful to make `gem rebuild` a little more usable, and
    it's already done by Bundler specs which already make this method a noop
    when they need this.
    
    I'm not sure forcefully setting this, even if user explicitly specified
    something else is helpful.
    
    Since this could potentially prevent gems explicitly setting a constant
    RubyGems version from building, I changed the error of incorrect
    RubyGems version from a hard error to a warning, since it will start
    happening in those cases if we stop overwriting the version.
    deivid-rodriguez committed May 3, 2024
    Configuration menu
    Copy the full SHA
    45676af View commit details
    Browse the repository at this point in the history