Warn if RubyGems version explicitly set in gemspec does not match running version #7460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duckinator Does this make sense to you? The idea is to remove any hurdles to eventually allow mocking the RubyGems version while building gems. We could use this for gem rebuild by using the RubyGems version used to build the original gem for the gem being rebuilt to hopefully eliminate the diff caused by the version mismatch. |
|
@deivid-rodriguez this seems reasonable, and I think it can be extended like you said to help |
deivid-rodriguez
force-pushed
the
remove-mark-version
branch
from
c5f73e4
to
5261076
Compare
deivid-rodriguez
changed the title
Gem::Specification#mark_versionThis gets in the middle if we ever start allowing to build as if using a different RubyGems version than the one being run. This could be useful to make `gem rebuild` a little more usable, and it's already done by Bundler specs which already make this method a noop when they need this. I'm not sure forcefully setting this, even if user explicitly specified something else is helpful. Since this could potentially prevent gems explicitly setting a constant RubyGems version from building, I changed the error of incorrect RubyGems version from a hard error to a warning, since it will start happening in those cases if we stop overwriting the version.
deivid-rodriguez
force-pushed
the
remove-mark-version
branch
from
5261076
to
45676af
Compare
|
Let's try this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
This gets in the middle if we ever start allowing to build as if using a different RubyGems version than the one being run.
This could be useful to make
gem rebuilda little more usable, and it's already done by Bundler specs which already make this method a noop when they need this.I'm not sure forcefully setting this, even if user explicitly specified something else is helpful.
What is your fix for the problem, implemented in this PR?
Since this could potentially prevent gems explicitly setting a constant RubyGems version from building, I changed the error of incorrect RubyGems version from a hard error to a warning, since it will start happening in those cases if we stop overwriting the version.
Make sure the following tasks are checked