Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer necessary code #7392

Merged
merged 1 commit into from Jan 19, 2024
Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

#7371 introduced a potential NoMethodError in the gem rdoc command. See 34df962#r1449105511.

What is your fix for the problem, implemented in this PR?

I believe this code is no longer necessary.

It was introduced a long time ago at e6e3c79. I guess "pseudo gems" meant default gems, and indeed passing a default gem to gem rdoc does not seem to generate any documentation nor log messages, however, it does not cause this rescue to be triggered, so I think rdoc must be swallowing whatever error internally.

Make sure the following tasks are checked

@hsbt hsbt merged commit 64eab6a into master Jan 19, 2024
74 checks passed
@hsbt hsbt deleted the deivid-rodriguez/fix-no-method-error branch January 19, 2024 03:18
deivid-rodriguez pushed a commit that referenced this pull request Mar 20, 2024
…-error

Remove no longer necessary code

(cherry picked from commit 64eab6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants