Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#7371 introduced a potential
NoMethodError
in thegem rdoc
command. See 34df962#r1449105511.What is your fix for the problem, implemented in this PR?
I believe this code is no longer necessary.
It was introduced a long time ago at e6e3c79. I guess "pseudo gems" meant default gems, and indeed passing a default gem to
gem rdoc
does not seem to generate any documentation nor log messages, however, it does not cause this rescue to be triggered, so I thinkrdoc
must be swallowing whatever error internally.Make sure the following tasks are checked