New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and correct rubocop failure #7371
Conversation
bundler/lib/bundler/rubygems_ext.rb
Outdated
@@ -282,7 +282,7 @@ def match_platforms?(platform, platforms) | |||
|
|||
# On universal Rubies, resolve the "universal" arch to the real CPU arch, without changing the extension directory. | |||
class BasicSpecification | |||
if /^universal\.(?<arch>.*?)-/ =~ (CROSS_COMPILING || RUBY_PLATFORM) | |||
if /^universal\.(?<arch>.*?)-/ =~ CROSS_COMPILING || RUBY_PLATFORM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a false positive in RuboCop. I've opened PR rubocop/rubocop#12607, but until that is resolved, it'll need to prevent false detections by using # rubocop:disable Style/RedundantParentheses
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your input!
@hsbt As per #7371 (comment), we may want to start using |
This is a piece of trivia and can be remembered in the same way as |
Makes sense, I guess the meaning was changed in v1, and that's why I thought |
I see. The concept of safety was not present initially, and there was only |
oh, I didn't know difference of I will use |
Update dependencies and correct rubocop failure (cherry picked from commit 8c6b6bc)
What was the end-user or developer problem that led to this PR?
In Ruby 3.3/3.4,
bin/rubocop
show the following warning.It fixed at recent released version of rubocop.
What is your fix for the problem, implemented in this PR?
I updated
tool/bundler/*.lock
and runbin/rubocop -A
each cop rule.Make sure the following tasks are checked